From 431a5914811a0cd717529680618d6d8c5fc18193 Mon Sep 17 00:00:00 2001
From: Connor Olding <cloningdonor@gmail.com>
Date: Fri, 8 Jun 2018 15:03:09 +0200
Subject: [PATCH] fix offscreen sprites sometimes being visible

---
 _NOTICE | 2 --
 smb.lua | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/_NOTICE b/_NOTICE
index 5cfa6d0..1e14cf2 100644
--- a/_NOTICE
+++ b/_NOTICE
@@ -7,8 +7,6 @@ TODOs: (that i can remember right now)
 - settle on a network architecture
 - detect frames when Mario is in a controllable state
 - compute how many input neurons the network needs instead of hardcoding
-- rewrite positions to be relative to Mario
-'-> fix offscreen sprites sometimes being visible to network
 - add some detection for enemies later in the game
 - fix cfg.enable_overlay (smb.lua doesn't see it being changed)
 
diff --git a/smb.lua b/smb.lua
index 71137ef..e11bd99 100644
--- a/smb.lua
+++ b/smb.lua
@@ -88,9 +88,9 @@ local function set_timer(time)
 end
 
 local function mark_sprite(x, y, t)
-    if t == 0 then
+    if t == 0 or x <= -8 or x >= 0xFF or y <= 0 or y >= 0xE8 then
         -- place unused/unseen sprites
-        x = -0x08 -- just off the left side of the screen
+        x = -8 -- just off the left side of the screen
         y = 0xC8 -- at ground level.
     end