From 6c75485bbb28ee63e8fa14ed1aa2a546a32ba5af Mon Sep 17 00:00:00 2001 From: Connor Olding Date: Sun, 2 Apr 2017 02:24:52 +0000 Subject: [PATCH] update kyaa --- kyaa.h | 4 ++-- kyaa_extra.h | 9 ++++++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/kyaa.h b/kyaa.h index 5efdda8..2f825a3 100644 --- a/kyaa.h +++ b/kyaa.h @@ -1,6 +1,6 @@ /* kyaa.h - macro hacks for handling main() arguments - license: public domain or whatever. - documentation is kept separate in kyaa.md + This is free and unencumbered software released into the public domain. + Refer to kyaa.md for documentation. */ #pragma once diff --git a/kyaa_extra.h b/kyaa_extra.h index 420dd67..77869f4 100644 --- a/kyaa_extra.h +++ b/kyaa_extra.h @@ -1,3 +1,8 @@ +/* kyaa_extra.h - extensions to kyaa for parsing arguments. + This is free and unencumbered software released into the public domain. + Refer to kyaa.md for documentation. +*/ + static char *kyaa_skip_spaces(char *str) { /* iterates str to first non-space character according to the C locale */ while (*str != '\0') { @@ -173,7 +178,8 @@ static const char *kyaa_str_to_long(char *str, long *p_out) { if (*str == '\0') return "no number given"; - // TODO: comment on how we go towards negatives instead of positives + // NOTE: we actually subtract each digit from the result instead of summing. + // this lets us represent LONG_MIN without overflowing. const char *err; switch (base) { case 2: { err = kyaa__base_2( &str, &out); } break; @@ -187,6 +193,7 @@ static const char *kyaa_str_to_long(char *str, long *p_out) { str = kyaa_skip_spaces(str); if (*str != '\0') return "unexpected character"; + // NOTE: out is negative here; see above comment. // assuming two's complement if (!negated && out == LONG_MIN) return "out of range for long integer"; *p_out = negated ? out : -out;