From 659bec36f80e80e24861287a40a6807efe45af1a Mon Sep 17 00:00:00 2001
From: Connor Olding <cloningdonor@gmail.com>
Date: Thu, 14 Jan 2016 17:08:56 -0800
Subject: [PATCH] reimplement defines

defines now resolve to the previous definition, rather than the lastmost.
also, defines are invisible to the parser now.
---
 lips/Muncher.lua |  2 +-
 lips/Parser.lua  |  3 ---
 lips/Preproc.lua | 52 ++++++++++++++++++++++++++++--------------------
 3 files changed, 31 insertions(+), 26 deletions(-)

diff --git a/lips/Muncher.lua b/lips/Muncher.lua
index 0e5c267..1a71bc9 100644
--- a/lips/Muncher.lua
+++ b/lips/Muncher.lua
@@ -14,7 +14,7 @@ function Muncher:advance()
     self.tok = t.tok
     self.fn = t.fn
     self.line = t.line
-    return t.tt, t.tok
+    return t
 end
 
 function Muncher:is_EOL()
diff --git a/lips/Parser.lua b/lips/Parser.lua
index ecad3dd..132bbcb 100644
--- a/lips/Parser.lua
+++ b/lips/Parser.lua
@@ -260,9 +260,6 @@ function Parser:parse(asm)
         elseif self.tt == 'EOL' then
             -- empty line
             self:advance()
-        elseif self.tt == 'DEF' then
-            self:advance()
-            self:advance()
         elseif self.tt == 'DIR' then
             self:directive()
         elseif self.tt == 'LABEL' then
diff --git a/lips/Preproc.lua b/lips/Preproc.lua
index 9f8dd6f..f870459 100644
--- a/lips/Preproc.lua
+++ b/lips/Preproc.lua
@@ -14,40 +14,45 @@ function Preproc:process(tokens)
     local plus_labels = {} -- constructed forwards
     local minus_labels = {} -- constructed backwards
 
-    -- first pass: collect tokens, constants, and relative labels.
+    -- first pass: resolve defines, collect relative labels
+    local new_tokens = {}
     self.i = 0
     while self.i < #self.tokens do
-        local tt, tok = self:advance()
-        if tt == 'DEF' then
-            local tt2, tok2 = self:advance()
-            if tt2 ~= 'NUM' then
+        local t = self:advance()
+        if t.tt == nil then
+            error('Internal Error: missing token')
+        elseif t.tt == 'DEF' then
+            local t2 = self:advance()
+            if t2.tt ~= 'NUM' then
                 self:error('expected number for define')
             end
-            defines[tok] = tok2
-        elseif tt == 'RELLABEL' then
-            if tok == '+' then
-                insert(plus_labels, self.i)
-            elseif tok == '-' then
-                insert(minus_labels, 1, self.i)
+            defines[t.tok] = t2.tok
+        elseif t.tt == 'DEFSYM' then
+            local tt = 'NUM'
+            local tok = defines[t.tok]
+            if tok == nil then
+                self:error('undefined define') -- uhhh nice wording
+            end
+            insert(new_tokens, {fn=t.fn, line=t.line, tt=tt, tok=tok})
+        elseif t.tt == 'RELLABEL' then
+            if t.tok == '+' then
+                insert(plus_labels, #new_tokens + 1)
+            elseif t.tok == '-' then
+                insert(minus_labels, 1, #new_tokens + 1)
             else
                 error('Internal Error: unexpected token for relative label')
             end
-        elseif tt == nil then
-            error('Internal Error: missing token')
+            insert(new_tokens, t)
+        else
+            insert(new_tokens, t)
         end
     end
 
-    -- resolve defines and relative labels
-    for i, t in ipairs(self.tokens) do
+    -- second pass: resolve relative labels
+    for i, t in ipairs(new_tokens) do
         self.fn = t.fn
         self.line = t.line
-        if t.tt == 'DEFSYM' then
-            t.tt = 'NUM'
-            t.tok = defines[t.tok]
-            if t.tok == nil then
-                self:error('undefined define') -- uhhh nice wording
-            end
-        elseif t.tt == 'RELLABEL' then
+        if t.tt == 'RELLABEL' then
             t.tt = 'LABEL'
             -- exploits the fact that user labels can't begin with a number
             t.tok = tostring(i)
@@ -78,12 +83,15 @@ function Preproc:process(tokens)
                     end
                 end
             end
+
             if seen ~= rel then
                 self:error('could not find appropriate relative label')
             end
         end
     end
 
+    self.tokens = new_tokens
+
     return self.tokens
 end